parisholley / wordpress-fantastic-elasticsearch

Improve wordpress search performance/accuracy and enable faceted search by leveraging an ElasticSearch server.
MIT License
162 stars 64 forks source link

Allow a more broader set of fields to be used as index & facet, plus allow indexing in other language #113

Closed peussen closed 9 years ago

peussen commented 9 years ago

In an last ditch effort to get this plugin working for me i added the following patches to the code base.

In short this changes the following things in the plugin

I added a unit test for the defaults filters i added. All other tests seem to work ok.

parisholley commented 9 years ago

Thanks for the pull (and tests!), I left a few comments on your commits. If you could make those tweaks, i'll get this pulled!

peussen commented 9 years ago

Concerning the filters in the Defaults file: I had to place them there, otherwise they won't show up in the admin content indexing screen, which eventually led to a lot of search failures because the index was not good enough. Setting it in config (which i tried), will not make the fields show up in the content_indexing screen at all.

parisholley commented 9 years ago

But what need is there to show it in the admin, if you are telling the system in code to index those fields?

peussen commented 9 years ago

Seems i'm not the only one who likes to show things in the admin as i saw another pull request doing the same ;)

I removed the filters for now. I figured out what went wrong, and it seems more something that has to do with the wipe data which creates a proper mapping, whereas rebuild index seems to lets elasticsearch figure it out..