search

paritytech / asset-transfer-api

Typescript API aiming to provide clear, and simple to use tools for transferring assets across common good parachains.
Apache License 2.0
43 stars 11 forks source link

fix!: always use limited calls #392

Closed marshacb closed 6 months ago

marshacb commented 6 months ago

Description

This PR removes support for creating reserveTransferAssets and teleportAssets calls which are now deprecated. Calls will now default to use limitedReserveTransferAssets or limitedTeleportAssets calls when appropriate.

This PR also removes the isLimited option when creating transfer transactions. In order to input a custom weight users now only need to provide a weightLimit option with their preferred refTime and proofSize values.

closes: #386

marshacb commented 6 months ago
  • Should we get rid of isLimited all together?
  • The README also needs to be updated.

We could remove isLimited and just consider whether the weightLimit option is provided to specify custom weights. Might be a simpler experience that way so Ill update with this in mind.

TarikGul commented 6 months ago
  • Should we get rid of isLimited all together?
  • The README also needs to be updated.

We could remove isLimited and just consider whether the weightLimit option is provided to specify custom weights. Might be a simpler experience that way so Ill update with this in mind.

Yea I think that is a great idea. It will definitely be simpler.

This would also make this a breaking change which is good so we can get all the breaking changes in 1 release.