search

paritytech / bench-bot

ISC License
9 stars 19 forks source link

add westmint, statemine, statemint runtimes #87

Closed gilescope closed 2 years ago

gilescope commented 2 years ago

necessary but possibly not sufficient

joao-paulo-parity commented 2 years ago

necessary but possibly not sufficient

It's not a big deal if it doesn't work right away as long as it does not breaking existing behavior, you can keep submitting new PRs with improvements and fixes. I'm fine with merging this even if it's not 100% correct (I don't know how to evaluate the commands TBH, hence why I ask for @shawntabrizi 's review here).

gilescope commented 2 years ago

I think someone has plumbed in benches via the ci now so we can close this.

joao-paulo-parity commented 2 years ago

I think someone has plumbed in benches via the ci now so we can close this.

@gilescope To be more precise, the current bench-bot is supposed to be replaced by /cmd queue -c bench-bot $ [args] (https://github.com/paritytech/command-bot#queue) which will work like the current bench-bot (https://github.com/paritytech/polkadot/pull/5478#issuecomment-1124042451 for example). We're waiting for https://github.com/paritytech/ci_cd/issues/431 to be done before publicizing the release of command-bot and advocating for its use.