Open statictype opened 1 year ago
Agreeing with all these points. 👍 In favor of this adapted flow. Also delaying the funding of the multisig stash to a later point. Streamlines the flow of adding the stash to the multisig.
- Fund stash same as before + loading and error states
This can also be an optional step after the proxy is created. e.g. after the account is created there can be a card saying: Congradulations! Would you like to fund your account, or sth in those lines, if that does make sense. Ideally the users also should see the balance of their stash accounts and fund them as needed, I believe.
3.2 Change ownership same as 3.1
Does this refer to the ownership of the multisig, or stash?!
@hamidra ownership in this case means which account has anyProxy rights for the stash account. because we spawn the pureProxy from a user account, this user account will own it. in step 3.2 we assign the multisig account as additional anyProxy for the stash and remove the user account, so that only the multisig account can control it.
Now that most chain interactions have been implemented for this flow, some problems come to light. This issue is about discussing how to improve UX and what makes sense to remove for the MVP.
There are some problems with the current multisig creation flow:
We could introduce 2 additional steps to better reflect what is actually going on. We need to sign 2 transactions, there is no way around that so it makes sense to have 2 separate steps for pureProxy creation and change of ownership. However, both these transactions need to succeed in order for the stash to be ready to use.
Currently, if for some reason one transaction fails, the multisig account has already been created but the user remains on step 2 where they can re-attempt the pureProxy creation process but also edit the signatories and create a new setup. This offers a level of flexibility that is not necessarily helpful and doesn't reflect what is actually going on.
It is also possible that the pureProxy creation succeeds and the change of ownership fails, in this case with the current flow we would need to persist the pureProxy address somehow instead of creating a new one which is a costly operation. The UI doesn't reflect these states.
New flow proposal
1. Multisig setup
2. Members
3.1 Create stash
3.2 Change ownership
4. Fund stash
Implications
The main implication of this flow is that the user needs to be able to complete step 3 at a later time and be able to pick up where they left. Suggestion: make the fund multisig feature available at a later time as well
Related issues
https://github.com/paritytech/capi-multisig-app/issues/187 https://github.com/paritytech/capi-multisig-app/issues/198 https://github.com/paritytech/capi-multisig-app/issues/190 https://github.com/paritytech/capi-multisig-app/issues/193 https://github.com/paritytech/capi-multisig-app/issues/191 - probably doesn't make sense with the new flow
Curious what your thoughts are @peetzweg @hamidra @Goranch3