search

paritytech / desub

Decode Substrate with Backwards-Compatible Metadata
GNU General Public License v3.0
39 stars 13 forks source link

support frame-metadata 15.0.0 #97

Closed gilescope closed 1 year ago

gilescope commented 2 years ago

v15 is here.

gilescope commented 2 years ago

got the main code compiling. working on the tests.

gilescope commented 2 years ago

tests compile. only the bitvec serialisation test fails now.

jsdw commented 2 years ago

My approach for this would be to have desub-current be a wrapper around https://github.com/paritytech/scale-value/, which uses frame-metadata 15 already, and IMO does a better job of decoding SCALE bytes anyway (especially everything bitvec related) :)

(a lot of scale_value stuff was taken from how desub-current was implemented anyway, so things are pretty similar)

gilescope commented 2 years ago

Yeah that would be ideal. I wasn't sure just how big a change that was? Also I was wondering if maybe the answer was a new crate that did what desub does but using scale-value. The reason I might be leaning towards that is desub-common has a lot of dependencies. I'm not convinced we need all of them and maybe a lot of them are due to the legacy? Thoughts?

jsdw commented 1 year ago

Closed by #115