search

paritytech / desub

Decode Substrate with Backwards-Compatible Metadata
GNU General Public License v3.0
39 stars 13 forks source link

upgrade to metadata v15 #98

Closed gilescope closed 2 years ago

gilescope commented 2 years ago

fixes #97. bitvec 1.0 the generic parameters have switched places.

bitvec now has order field when serialising though maybe we don't need to as we are only ever going to use one ordering.

gilescope commented 2 years ago

I see @nathanwhit has done a lot of this work already. I shall try and redo this PR on top of his fork. https://github.com/nathanwhit/desub/commit/7e5ed38ac75e05b8fd4f44a2da6b346c34dd774a (thanks Wigy for pointing that out!)

jsdw commented 2 years ago

Just to take my issue comment into here incase it wasn't spotted:

My approach for this would be to have desub-current be a wrapper around https://github.com/paritytech/scale-value/, which uses frame-metadata 15 already, and IMO does a better job of decoding SCALE bytes anyway (especially everything bitvec related). I for one wouldn't want to maintain two versions of the encode/decode logic :)

(a lot of scale_value stuff was taken from how desub-current was implemented anyway, so things are pretty similar)