search

paritytech / email-verification

e-mail verification for Parity.
https://github.com/ethcore/email-verification#parity-e-mail-verification
Other
8 stars 4 forks source link

An in-range update of node-mailjet is breaking the build 🚨 #17

Open greenkeeper[bot] opened 6 years ago

greenkeeper[bot] commented 6 years ago

The dependency node-mailjet was updated from 3.2.1 to 3.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

node-mailjet is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build could not complete due to an error ([Details](https://travis-ci.org/paritytech/email-verification/builds/435463886?utm_source=github_status&utm_medium=notification)).
Commits

The new version differs by 15 commits.

  • 78af682 Merge pull request #62 from mailjet/feature/add-v4-and-sms
  • 30bf2fa Merge pull request #61 from YV-Proxiad/feature/Add-v4-and-sms
  • 1b34c64 Merge pull request #3 from YV-Proxiad/travic-ci-integration
  • 2d889e2 travic-ci-integration
  • 54c3d4c travic-ci-integration
  • 7e6b540 Merge pull request #1 from YV-Proxiad/feature/Add-v4-and-sms
  • 1e47b5b updated: Travis CI building tool works with same config when testing, so version needs to be specified for each functionality (Email/SMS)
  • 17a69e2 fixed: legacy tests backslash issue
  • 027d3b7 code refactored
  • 128b87e removed: unnecessary code comment
  • 63230a1 mailjet sms api v4 feature
  • 6840abd Merge pull request #41 from jordansexton/patch-1
  • 87aafb1 fixed bad require (referenced in #36)
  • feb9b47 Formatting and add slack notifications
  • bd0e9ef Update readme logo version

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 3.2.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 6 years ago

Your tests are still failing with this version. Compare changes

Release Notes for Bug fix

Perform api call - now return Promise in order to be the same as real Mailjet api call
Error handling - able to get status, response and reason and return proper error message

Commits

The new version differs by 5 commits.

  • 1acbdcc fixed: promise call tests
  • 8e112bb updated: version updated to 3.3.1
  • 047faa4 fixed: perform_api_call to return new promise
  • c05c287 fixed: test case for error message
  • 8284ed5 FIX: error-handling

See the full diff