[evm-tracing] Adding Moonbeam's implementation.

paritytech / extended-parachain-template

Node template to build parachains with all the required pallets. Slightly opinionated based on what majority of parachain teams are using.

The Unlicense

27 stars 19 forks source link

[evm-tracing] Adding Moonbeam's implementation. #13

Closed weezy20 closed 1 year ago

weezy20 commented 1 year ago

Currently compilation fails only due to the use of #[allow(deprecated)] attribute which is an experimental feature as of now. Disabling the attribute results in a compilation warning.

gautamdhameja commented 1 year ago

We should not be copy-pasting anything. Steve has brought good points above. Let's try to find a way where we can do things differently. Maybe fork the external repo and make our changes, and then integrate the fork as a dependency. Also, make it optional for teams to integrate it. Make sure it is clearly mentioned in the readme.

stiiifff commented 1 year ago

Also for reference: Support debug trace RPC APIs

weezy20 commented 1 year ago

There are still some issues with the try-runtime feature not building. Will sort that one up and then I think it should be finally ready.

stiiifff commented 1 year ago

CI failing but looks fine locally. To be addressed in a separate issue. LGTM