paritytech / extended-parachain-template

Node template to build parachains with all the required pallets. Slightly opinionated based on what majority of parachain teams are using.
The Unlicense
27 stars 21 forks source link

Configure 2/3 threshold multisig for Sudo on Mainnet #69

Closed weezy20 closed 1 year ago

weezy20 commented 1 year ago
weezy20 commented 1 year ago

Added a short document to explain the governance model around sudo-multisig, pallet-collective + pallet-motion. Request your review and feedback @peterwht @stiiifff @evilrobot-01 @Moliholy

evilrobot-01 commented 1 year ago

FYI - we debated on whether to keep codec dependency alias on my recent PR, but found it introduced build warnings unfortunately, hence using the actual dependency name instead.

peterwht commented 1 year ago

It would be good to add some documentation highlighting that the multisig signatories MUST have funds.

weezy20 commented 1 year ago

It would be good to add some documentation highlighting that the multisig signatories MUST have funds.

Could you please elabore a bit more on that?

stiiifff commented 1 year ago

@weezy20 cfr. @peterwht remark, the Multisig account must be pre-funded (so be included in the endowed accounts of the balances pallet in the genesis). See here. Also, add a comment to make it clear & explicit on why this is needed.

evilrobot-01 commented 1 year ago

Worth adding a test?

peterwht commented 1 year ago

To elaborate more. Yes, the multisig account must be funded. But each signatory must be funded as well otherwise they can not vote for something to be executed for the multisig account.

If the multisig is funded but the signatories are not, then the multisig is unusable and the chain is potentially unusable. The chain-spec's example will work fine, but I think it is worth adding some bold warnings for anyone wanting to do this.