search

paritytech / helm-charts

Parity & Polkadot Helm charts collection
GNU General Public License v3.0
27 stars 22 forks source link

[node] BUG: parachain flags affect relaychain node #324

Closed BulatSaif closed 9 months ago

BulatSaif commented 9 months ago

Setup:

Running a Rococo node, in the common values file, I've included the following line:

collatorExternalRelayChain:
  enabled: true

This common values file is utilized for deploying both the relay chain and parachains.

Current Behavior:

The listen-addr flag has been removed from the node:

--listen-addr=/ip4/0.0.0.0/tcp/30333

Expected Behavior:

The parachain flags should not take effect unless the isParachain: true parameter is set in the values file.

Code Line with Bug:

Here is the problematic line of code.

BulatSaif commented 9 months ago

same issue: if collatorExternalRelayChain.enabled or collatorLightClient.enabled is set

  1. service node-0-relay-chain-p2p should not be created
  2. --public-addr=/ip4/${EXTERNAL_IP}/tcp/${RELAY_CHAIN_P2P_PORT} \ flag should be removed