paritytech / helm-charts

Parity & Polkadot Helm charts collection
GNU General Public License v3.0
25 stars 22 forks source link

[node] helm chart should fail if passed no values #355

Closed BulatSaif closed 3 weeks ago

BulatSaif commented 3 weeks ago

Fixes: https://github.com/paritytech/helm-charts/issues/248

It's common that due to YAML indentation issues (especially when a chart is used as a dependency) the override node block is not passed correctly. This can result in the node being deployed with default values, leading to confusion since the deployment succeeds, but the node may end up syncing the wrong chain, wasting time.

Changes

  1. Unset the chain parameter.
  2. Make chain a required parameter.