refactor(client): remove MaxSlots limit

paritytech / jsonrpsee

Rust JSON-RPC library on top of async/await

MIT License

629 stars 169 forks source link

refactor(client): remove MaxSlots limit #1377

Closed niklasad1 closed 4 months ago

niklasad1 commented 4 months ago

Close #1374

The rationale behind this is that the "ws-client/async-client" already has a bounded channel which provides backpressure and it doesn't make sense to use slot limit to throw an error if it's exceeded.

For the http client it's another story where it's handled by the hyper threadpool and we have no channel that provides backpressure.

However, it's better that users themselves decide how many concurrent calls that they want...

nazar-pc commented 4 months ago

When is new release planned? I'd love to upgrade to use this

niklasad1 commented 4 months ago

Hey, we are planning a new breaking release 0.23/1.0 soon hopefully next week but it has some big changes such as moving to hyper v1.0 and I need to do some manually testing on it....