fix bincode deserialization - Githubissues

paritytech / libsecp256k1

Pure Rust Implementation of secp256k1.

Apache License 2.0

172 stars 84 forks source link

fix bincode deserialization #110

Closed steverusso closed 2 years ago

steverusso commented 2 years ago

Currently, the current bincode de/serialization has a bug:

When serializing, a byte array is used from the PublicKey::serialize method.
Then when deserializing, the attempt is made by default to deserialize directly into a PublicKey instead of calling the corresponding PublicKey::parse_slice function.

Additionally, bincode serialization isn't covered in the tests.

Therefore, this PR does the following:

Implement and use a new PublicKeyBytesVisitor for deserializing bytes to a PublicKey (Closes #97).
Add a test to cover bincode serialization / deserialization.
Return the base64 decoding error instead of unwrapping (Closes #105).

Parth commented 2 years ago

Hey @sorpaas,

when will we see this deployed to crates?