Fix ec multiplication under release

paritytech / libsecp256k1

Pure Rust Implementation of secp256k1.

Apache License 2.0

175 stars 84 forks source link

Fix ec multiplication under release #60

Closed andresilva closed 4 years ago

andresilva commented 4 years ago

There were some debug_assert!s with side-effects. These would not be run under release builds. Looking at all debug_assert!s I didn't find other instances where the same mistake was made but please double check as well.

Fixes #58.

andresilva commented 4 years ago

It might make sense to also run tests on CI under release build.

LLFourn commented 4 years ago

Haha nice find. I think it makes sense to include that in this PR?

sorpaas commented 4 years ago

https://github.com/paritytech/libsecp256k1/pull/61 for CI tests of release build.