paritytech / litep2p

Peer-to-peer networking library
MIT License
65 stars 7 forks source link

clippy: Revisit allowed clippy rules #85

Open lexnv opened 4 months ago

lexnv commented 4 months ago

Revisit the allowed clippy rules introduced by: https://github.com/paritytech/litep2p/pull/83.

A few notes on them:

https://github.com/paritytech/litep2p/blob/08112ca642cea3809625ae0abde05dc0dc46b4f3/src/error.rs#L115

dmitry-markin commented 4 months ago

PeerIdMismatch(PeerId, PeerId) this one is used by https://github.com/dmitry-markin/p2p-probe to detect the correct PeerId.

dmitry-markin commented 4 months ago

Currently ignored clippy lints for context: https://github.com/paritytech/litep2p/blob/5c37774d0b377430bad408a6f7ed5e9f1ff53c7f/src/lib.rs#L21-L29