Extract reusable features from gitspiegel

paritytech / opstooling-js

Shared functionality for OpsTooling projects

https://www.npmjs.com/package/@eng-automation/js

Apache License 2.0

0 stars 1 forks source link

Extract reusable features from gitspiegel #4

Closed joao-paulo-parity closed 2 years ago

joao-paulo-parity commented 2 years ago

was there any usages before this rename? looks like a breaking change?

It isn't because the file is not consumed directly, everything is exported from index.ts

this has some type data transformation, which would be better to cover with unit tests

Sure, https://github.com/paritytech/opstooling-js/issues/7. I'm not doing it in this pull request because the file was not introduced here, so it's out of scope.

joao-paulo-parity commented 2 years ago

@mordamax Regarding the return function type comments I'll need your input in https://github.com/paritytech/opstooling-js-style/pull/4. After that we can have a follow-up PR for updating the opstooling-js-style dependency and applying the rule project-wide.