search

paritytech / parity-bridges-ui

bridge-ui-substrate-draft
GNU General Public License v3.0
18 stars 8 forks source link

Avoid using `derived` in code and unify naming to `companion`. #119

Open tomusdrw opened 3 years ago

tomusdrw commented 3 years ago

derived is too technical for users, and companion might be easier to explain.

Ideally during display we should show the chain name as well, so that it's something like:


RialtoAlice - original account from Rialto
millauCompanion(RialtoAlice) - companion account on Millau
tomusdrw commented 3 years ago

I think it shouldn't have been closed yet. The display is okay, but we might want to consider renaming the variables internally in the code as well. That's the reason I didn't close the issue in #118.

hbulgarini commented 3 years ago

I think it shouldn't have been closed yet. The display is okay, but we might want to consider renaming the variables internally in the code as well. That's the reason I didn't close the issue in #118.

OK makes sense

hbulgarini commented 3 years ago

PR #165 is not enough. Still need to be addressed.