search

paritytech / parity-common

Collection of crates used in Parity projects
https://www.paritytech.io/
Apache License 2.0
290 stars 218 forks source link

Remove `parity-util-mem` #696

Closed mrcnski closed 1 year ago

mrcnski commented 1 year ago

PULL REQUEST

Overview

Removes parity-util-mem from kvdb, kvdb-memorydb and kvdb-rocksdb.

Note that we will still need to update the versions, changelogs, and git tags for these crates, and then publish them. I can do that in this PR, if desired, or someone else can.

Related Issues

See https://github.com/paritytech/substrate/issues/12658.

mrcnski commented 1 year ago

Would be nice to update changelogs as well. I'd prefer to see substrate removing references to it first.

I can update changelogs. What about versions in Cargo.toml?

The substrate PR:

https://github.com/paritytech/substrate/pull/12795

ordian commented 1 year ago

Ok, I'll update versions and changelogs and take care of publishing.

Could you remove references to parity-util-mem in CI: https://github.com/paritytech/parity-common/blob/master/.github/workflows/ci.yml?