paritytech / parity-common

Collection of crates used in Parity projects
https://www.paritytech.io/
Apache License 2.0
282 stars 213 forks source link

kvdb-rocksdb: support the rocksdb/multi-threaded-cf feature #838

Open cchudant opened 5 months ago

cchudant commented 5 months ago

The rocksdb crate supports a feature called multi-threaded-cf, which wraps column family descriptors into RwLocks. and change some types around. Enabling it in a downstream app makes kvdb-rocksdb then fail to compile.

Questions:

ordian commented 1 month ago

should I add a compile test to the CI to make sure future changes compile under that rocksdb flag?

yes, please

do you think we should also expose this feature in kvdb-rocksdb? as in

[features]
# ...
multi-threaded-cf = ["rocksdb/multi-threaded-cf"]