search

paritytech / parity-common

Collection of crates used in Parity projects
https://www.paritytech.io/
Apache License 2.0
290 stars 218 forks source link

fixed-hash: remove `byteorder` feature #872

Closed koushiro closed 1 month ago

koushiro commented 1 month ago
koushiro commented 1 month ago

@ordian PTAL

koushiro commented 1 month ago

the changes makes sense to me. unfortunately, they are semver breaking which will lead to version bump propagation everywhere

I will submit a few more PRs after this, they will also result in breaking changes.

ordian commented 1 month ago

please also fix this: https://github.com/paritytech/parity-common/blob/366a95cdf1a10b4870b1d780f11748c76fecc4a8/.github/workflows/ci.yml#L70

koushiro commented 1 month ago

@bkchr PTAL