search

paritytech / parity-extension

Parity Chrome Extension
GNU General Public License v3.0
37 stars 14 forks source link

Popup window for the extension #36

Closed ngotchac closed 7 years ago

ngotchac commented 7 years ago

Very basic popup for the Extension ; right now the user can only enable / disable the extension

(included Material Design Lite)

tomusdrw commented 7 years ago

Why do we need popup for this? Wouldn't it be better to have Options page instead?

ngotchac commented 7 years ago

I was wondering what is the best, yes... So it might not be necessary for enable/disable purposes, but at least there's all the structure for it. Can ditch the checkbox then. But I thought it could be nice to have the popup to show for example the current Ethereum Accounts that have been found on the page... There might be other purposes, like network status (connected/connecting/disconnected) ? Or if we don't want the auto-reconnect logic, the user could reconnect to the node by clicking on a button in the pop-up

ngotchac commented 7 years ago

(The idea is not to only have this checkbox, but this PR would be just a first step. If you think that an Option page is sufficient, I'll port the code to an Option page)

tomusdrw commented 7 years ago

I think such checkbox should go to the Options page, on popup we can show the addresses as you mentioned and node status (is it online and connected).

That said if it's just initial content of the popup page that is expected to be superseded by something like above in future then I'm ok with this.

ngotchac commented 7 years ago

@tomusdrw Yes that's was I meant. The enable/disable feature was to try out the pop-up ; and we can always keep the logic to use it in an option page

ngotchac commented 7 years ago

@tomusdrw Ok, updated the PR. Now the content scripts are always loaded, but check if the extension is enabled before doing anything