search

paritytech / parity-extension

Parity Chrome Extension
GNU General Public License v3.0
37 stars 14 forks source link

Don't assume that the iframe is on the bottom-right #68

Closed ngotchac closed 7 years ago

ngotchac commented 7 years ago

Place the iframe and set the correct width and height of the Parity Signer Bar iframe on load and when the close event is fired.

This is the first step for paritytech/parity#4886 Second step is here : paritytech/parity#4987

ngotchac commented 7 years ago

Updated the PR ! Seems to work ok. To test :

Run NODE_ENV=production npm run build && node webpack/build.server.js for the UI Set 127.0.0.1:3000 in the Extension options

tomusdrw commented 7 years ago

Opening and Closing signer on older version of Parity embed code works very slowly. (it opens fast, but after closing the modals stays open for couple of seconds).

tomusdrw commented 7 years ago

Issues I've found:

  1. Slow closing of signer
  2. Initial size is incorrect (too small) so the texts are not displayed (only icons). Actually this sometimes happens randomly, perhaps the size is not calculated correctly? What about some sane minimal values?
  3. The bar flickers when dropped.
tomusdrw commented 7 years ago

@ngotchac How is the progress going on this?

ngotchac commented 7 years ago
  1. Will look into this, we have to find a better way of closing, but it's not trivial since there could be some animations involved (thus closing slowly)
  2. It has happened to me as well. It is a bit random, so some minimum would be good yes :)
  3. I tried to mitigate this but couldn't find a way... :( But I think it was already happening before when opening the Signer, no ?
tomusdrw commented 7 years ago
  1. Wouldn't using ontransitionend event solve that?
  2. :+1:
  3. Didn't notice that before, but possibly it was already happening before. We can log this as a separate issue to investigate.
ngotchac commented 7 years ago

Updated the PR. The flickering is annoying but couldn't find the reason...

tomusdrw commented 7 years ago

So the extensions stopped working correctly for me. I'm not sure if it was introduced by this PR (will do some more testing), but version from the store works correctly.

It complains that the transport is not initialized all the time and there are some errors regarding blocked resources.