search

paritytech / parity-extension

Parity Chrome Extension
GNU General Public License v3.0
37 stars 14 forks source link

No firefox support #87

Open 3esmit opened 7 years ago

kekkyojin commented 7 years ago

It needs to use WebExtensions. Most of the lines with chrome. should be replaced by browser.

Like in chrome.browserAction.setIcon ------> browser.browserAction.setIcon.

Source: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities

I have just 'npm run release' the repo code and it builds, excepts it tries to do something with the Chrome.app file. It builds corectly and the extension can be loaded by going to about:debugging, then "load temporary addon" (maybe not the correct wording as I am not using an English locale Firefox) and search for the parity-extension/release/source/manifest.json. That will load without problems.

However the extension is not working fine, maybe because it is using those chrome.* API calls.

3esmit commented 6 years ago

It says merged but I don't see it for download anywhere.

tomusdrw commented 6 years ago

Hi @3esmit, initial support is indeed merged. We haven't yet manage to release it to Firefox store. I'll release a new version over the weekend and will publish built package on github.

3esmit commented 6 years ago

Thanks, I only use Firefox because I'm using the most open source software as possible, and installing Chrome is essentially trusting with blind eyes Google. Although I have Chromium installed only because of Parity Extension, but Firefox, IMO, is the best and safest. Can't wait to remove Chromium :laughing:

BlinkyStitt commented 6 years ago

I'm excited to try this out with the new firefox! Thanks for the hard work.

makew0rld commented 6 years ago

What happened to the firefox extension?

tomusdrw commented 6 years ago

@Cole128 Firefox-compatible extension is available to download on releases page. It's still not in Firefox store (help to remove eval from the codebase/build welcome!)

makew0rld commented 6 years ago

@tomusdrw downloading and installing the zip doesn't work unfortunately.

makew0rld commented 6 years ago

It may need to be in .xpi format, I'll try and repackage it.

Edit: So it appears this is probably because the extension doesn't follow rules listed here, namely an install.rdf file, and the extension being a .xpi file instead a .zip

kekkyojin commented 6 years ago

Firefox extensions must be held in .xpi files, although they are just renamed .zip files.

And WebExtensions doesn't use install.rdf. Instead manifest.json must be used: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Comparison_with_XUL_XPCOM_extensions

tomusdrw commented 6 years ago

It is possible to unpack the zip file and use "Debug Add-On" option in Firefox to load the extension (point to manifest.json).

kekkyojin commented 6 years ago

Oh, yes. I forgot that option.