paritytech / parity-processbot

GNU Lesser General Public License v3.0

11 stars 8 forks source link

processbot features which are intended to be removed or deprecated #356

Open joao-paulo-parity opened 2 years ago

joao-paulo-parity commented 2 years ago

Deprecated

[x] https://github.com/paritytech/parity-processbot/issues/371
[ ] merge master, to be deprecated in favor of pre-merge pipelines which should already take master into account without pushing commits to the branch

Removed

[x] https://github.com/paritytech/parity-processbot/issues/333

Could be removed, but requires more work

[ ] Lockfile updates after bot merge could be removed if the companion build system would be redesigned such that bot commits are no longer needed (#327)

Suggestions

bot rebase (or any other developer-facing merge-automation task) could be moved to another project focused on event processing (front-end) so that processbot can focus on the backend processing of the companion build system

TriplEight commented 2 years ago

bor merge (or bor merge $branch) comment. My idea is the backend should be implemented within pre-merge pipelines tool. Whereas the "frontend" as in reading the comment from PR should remain in the processor.

this logic is already implemented in pre-merge pipelines tool
the result of bot merge does the same as the pre-merge tool (but also pushes the commit). So it can do all the following tool's activities. And then one can put the automerge label and it merges if all goes well.