paritytech / parity-publish

A tool to manage publishing Parity's crates
Apache License 2.0
4 stars 1 forks source link

Tracking of external deps in root manifest #36

Open Morganamilo opened 4 months ago

Morganamilo commented 4 months ago

When an external dependency is bumped in the root manifest file, parity publish has no way to see this. The PR author must correctly declare all packages that the dep change effects.

If they are not declared, then the effected packages won't be marked for release. This is a big issue when the external dependency is visible in our public API.

This happened during the 1.14 release. One package using an external dep never got marked for release while another did. When publishing, eventually we got to a package depending on both. This caused a failure due to two incompatible versions of a library being used.