paritytech / parity-react-scripts

An extension of the react scripts for Parity-based dapps
3 stars 3 forks source link

react-scripts-config vs react-app-rewired #7

Open amaury1093 opened 6 years ago

amaury1093 commented 6 years ago

Hey @ngotchac,

I tried to understand how you wired everything together. If I understood correctly, your fork react-scripts-config reads the config from process.env.CONFIG and merges it on top of the default CRA config.

If yes, I believe it's very similar to https://github.com/timarney/react-app-rewired.


The one big disadvantage I see in using a in-house forked react-scripts it that we'd need to maintain that package constantly, i.e. merge changes from upstream (which is an active project).

My idea, if it's possible/easy, is to use react-app-rewired. The maintainer + 1.2k stars community takes care of merging upstream, plus it has already some tools that you're adding manually (like babel plugins for mobx). And looks pretty flexible to extend.

Tell me what you think.