Discussion: Adding more modules vs Staying close to CRA

[amaury1093]

In #2, #3, #4 you are adding more plugins on top of the default CRA webpack config. They are nice-to-have features, but I'm not sure they're necessary.

I would suggest to stay as close as possible to CRA, i.e. not to add any additional webpack plugins unless absolutely life-changing, for the following reasons:

• CRA is popular, almost a standard.
• Less potential errors on our side. I would not like to see a dapp that runs with CRA's react-scripts, but not with parity-react-scripts.
• Less maintenance on our side.

More concretely, in react-scripts.config.js, I would:

• Keep devPort, openBrowser, htmlPlugin, some babel plugins. Necessary for dapp development.
• Remove circular-dependency-plugin (didn't see the use of it?)
• Remove PostCss (would rather rewrite v1 not to use it, or use sass which is cra-compatible)
• Do not add features in #3 and #4 unless convinced otherwise.

cc @jacogr

[ngotchac]

So for the circular dependencies, it can be quite useful for resolving some bugs. It's actually always better to avoid having circular dependencies anyway, and this doesn't break anything, just adds some warnings.

Regarding post-css, it's actually already included in CRA. This just adds more plugins.