search

paritytech / parity-tokio-ipc

Parity tokio-ipc
Apache License 2.0
76 stars 48 forks source link

Perform some clean up #13

Closed Xanewok closed 5 years ago

Xanewok commented 5 years ago

I did some hacking to see if we can get rid of explicit handles in NamedPipes and while working on it I figured this crate could use a refresh so here it is!

Not feeling particularly strong about any of the changes, feel free to skip some if you don't believe it's a good direction.

Xanewok commented 5 years ago

Rebased and bumped rand to 0.7. I tried to get rid of explicit dependency on tokio_uds but it seems we're using tokio_uds::Incoming which is not directly exposed in tokio under uds feature so I left it as is.

One thing we could do is drop futures and move to std::future::Future but IIUC that requires a coordinated switch along with parity/jsonrpc.