Spotted when trying to migrate jsonrpc to futures 0.3 (WIP @ https://github.com/paritytech/jsonrpc/commit/51c2feeaebcf26ca421f59658dd79cc23a2a14ae). Ideally, we should consume self in both Windows and Unix cases - having one method borrow &self leads to lifetime issues and a grumpy compiler. Instead, I opted to consume self similarly to what previous implementation (futures 0.1) did and what is currently implemented for Windows.
Spotted when trying to migrate jsonrpc to futures 0.3 (WIP @ https://github.com/paritytech/jsonrpc/commit/51c2feeaebcf26ca421f59658dd79cc23a2a14ae). Ideally, we should consume
selfin both Windows and Unix cases - having one method borrow&selfleads to lifetime issues and a grumpy compiler. Instead, I opted to consumeselfsimilarly to what previous implementation (futures 0.1) did and what is currently implemented for Windows.cc @seunlanlege for the current impl