search

paritytech / parity-tokio-ipc

Parity tokio-ipc
Apache License 2.0
76 stars 48 forks source link

Add client support #5

Closed pinkisemils closed 6 years ago

pinkisemils commented 6 years ago

I've added better client support for this library, where one can create a valid IpcConnection that connects to a listener on both Windows and Unix platforms. This really is required mostly because on Windows this necessitates non-standard flags for the client connection.

NikVolf commented 6 years ago

Very nice!

NikVolf commented 6 years ago

Test fail though, probably timeout?

pinkisemils commented 6 years ago

Seems like that was just a faulty travis machine, as there is no output whatsoever https://travis-ci.org/NikVolf/parity-tokio-ipc/jobs/412720072#L1. I'll try and push with a dummy commit, the previous tests worked just fine.

NikVolf commented 6 years ago

Well it might actually mean random timeouts, but i will merge for now

We have some tests in jsonrpc-ipc-server for this, so make sure you have also some upstream tests

pinkisemils commented 6 years ago

I wouldn't worry too much, usually we'd at least see some compiler output when running the tests, right? Thanks for the timely merge :+1: