paritytech / polkadot-launch

Simple CLI tool to launch a local Polkadot test network
MIT License
459 stars 93 forks source link

Make runner reusable #142

Closed joelamouche closed 3 years ago

joelamouche commented 3 years ago

Two issues were preventing to call the runner more than once in a sequence (necessary for running multiple tests sequentially):

joelamouche commented 3 years ago

@shawntabrizi this is a prerequisite for #132

joelamouche commented 3 years ago

@shawntabrizi Please review this when you have the time

shawntabrizi commented 3 years ago

If I remember correctly, I didn't do it this way because this messes with submitting multiple txs in the same block. Here, if nonce is called twice where there is some tx still in queue, the nonce in storage will be returned which is not correct for submitting multiple transactions.

shawntabrizi commented 3 years ago

You should def DM me on Riot if you dont see me review your code in a timely manner. For whatever reason, sometimes these review requests fall of my github notifications.

joelamouche commented 3 years ago

If I remember correctly, I didn't do it this way because this messes with submitting multiple txs in the same block

I see. But in that case we're not doing more than once tx in a block for the setup. I could replace with nonce=-1 as per https://polkadot.js.org/docs/api/cookbook/tx/ if you think it's valuable