search

paritytech / polkadot-launch

Simple CLI tool to launch a local Polkadot test network
MIT License
460 stars 93 forks source link

Remove Parachain ID Parameter #151

Open HCastano opened 2 years ago

HCastano commented 2 years ago

Due to https://github.com/paritytech/cumulus/pull/739 polkadot-launch isn't able to launch collators properly since it makes use of the --parachain-id flag. We should update the tool accordingly.

nuke-web3 commented 2 years ago

bummer. I will make a note in the tutorial, and watch for this to be resolved to re introduce using this great tool.

might need some plain chainspecs and a bit of find and replace magic now to get raw specs to use here?

brunopgalvao commented 2 years ago

Currently the polkadot-launch config.json parachains id values are overridden by this line in cumulus:

1000.into(),

this makes it challenging to have polkadot-launch spin off multiple parachains with different ids.

Just to be clear, the parachain ids are being picked up off of the config file for the relay chain but not for the individual parachain nodes they are defaulting to 1000 because they are hardcoded in cumulus.

Screen Shot 2022-03-03 at 10 21 14 AM Screen Shot 2022-03-03 at 10 22 12 AM

Any ideas on best course of action?

tagging: @Imod7 @al3mart

al3mart commented 2 years ago

So, the id that you specify in the config file for polkadot-launch is the one that will be reserved in the relay chain and for which the state and wasm of the para will be registered, and only that.

The paraId on the state of the para will be defined by whatever exits on the chain_spec that para is running. What you have linked in your comment is the genesis config where you can see the value 1000 being set as the paraId in the state of the para.

On the topic of the issue itself, current master branch of polkadot-launch doesn't add --para-id flag when running the collators, so maybe it will be a good moment for a new (minor?)version of the tool.

(closed by misclick, reopening)