search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.63k stars 576 forks source link

[asset-conversion] Add runtime api to polkadot-js/api #108

Open bkontur opened 12 months ago

bkontur commented 12 months ago

E.g.: FungiblesApi: https://github.com/polkadot-js/api/blob/3f90f72bd69c49a7ef6902366572c90c1efcdb52/packages/types/src/interfaces/fungibles/runtime.ts

jsidorenko commented 11 months ago

https://github.com/polkadot-js/api/pull/5694

joepetrowski commented 10 months ago

Needs https://github.com/polkadot-js/api/pull/5700

NachoPal commented 5 months ago

Can it be closed? both PRs are already merged, not sure if there is still something missing or not.

jsidorenko commented 5 months ago

As I see, this issue is still open: https://github.com/paritytech/polkadot-sdk/issues/1129 ,@bkontur, could you comment on this pls?

bkontur commented 5 months ago

iirc, initially, we've added some stuff to the polkadot.js, but I am not sure if it is still compatible, because there were several refactors in asset-conversion pallet, so we should check this.

@franciscoaguirre Cisco has already fixed some stuff within XCMv4, I would say we need to revisit that #1129 again, what would be the best option

franciscoaguirre commented 5 months ago

I pinned version 3 so we can do a storage migration whenever

bkontur commented 5 months ago

yes, one thing is storage and another thing is public APIs for indexers/wallets and so on, maybe for them it would be better to use Versioned* stuff, not to break when we change XCM version for storage items, if Location is not compatible.

Another thing, I think we should maybe add some try-runtime / try-state stuff, which would check actual data if they are compatible with actual XCM version used for storage items - but this would be a separate issue. At least, we will see if we can do runtime upgrade or not.