Child bounty improvements

xlc commented 2 years ago

Should have event for propose_curator, accept_curator
https://github.com/paritytech/substrate/blob/89fcb3e4f62d221d4e161a437768e77d6265889e/frame/child-bounties/src/lib.rs#L889-L895 this is just bad code. a method without verb that does something.
https://github.com/paritytech/substrate/blob/89fcb3e4f62d221d4e161a437768e77d6265889e/frame/bounties/src/lib.rs#L603-L606 this is redundant. it is only possible to award a bounty when there are no open child bounty and therefore the fee must be zero. and it doesn't make sense.

vishnuc77 commented 2 months ago

Hi @xlc , I’m a first-time contributor and interested in getting started with the project. I have basic experience working with substrate based chain. If this still needs to be fixed, can i take it up?

ggwpez commented 2 months ago

There is a umbrella issue for this, not sure if someone is on it but its pretty involved: https://github.com/paritytech/polkadot-sdk/issues/5033

vishnuc77 commented 2 months ago

Got it. Thanks!

paritytech / polkadot-sdk

Child bounty improvements #1141