Open xlc opened 10 months ago
map_err
is not ignoring the error, it just maps it... as the name is already hinting.
but |_|
is ignoring it and it looks like a sad face
Should probably still be logged to ease debuggability.
Hi @xlc, I am interested in working on this, my assumption is for occurrences of .map_err(|_|
, it would look like this
.map_err(|e| { log::error!(target: "xcm::pallet_xcm::function_name", "Some description: {:?}", e);
yes
_Originally posted by @xlc in https://github.com/paritytech/polkadot-sdk/pull/2405#discussion_r1398704951_
Need to make sure every
.map_err(|_|
are justified with good reasons.