The rest of the way to Weights V2 (Tracking Issue)

[shawntabrizi]

Here is a tracking issue for all the steps I can think of, before we need to start going through all the various runtime logic, and actually use the new multi-dimensional weights v2.

• [x] deprecate RefTimeWeight https://github.com/paritytech/substrate/pull/12157
• [x] Remove Ord from the one dimensional weight type paritytech/substrate#12183
  • [x] implement any_gt any_lt all_gt all_lt (and the equal to variant)
  • [x] go through each comparison operator usage, and CAREFULLY make sure that it uses the correct version of any_* or all_*. This is super important, because it could lead to bugs if incorrectly implemented, and we have 2 dimensional weights.
• [x] Move some basic type definitions to a new crate called sp-weights paritytech/substrate#12219
• [x] Then, I think we can finally add the second field to Weight without any worry, and just some storage migrations paritytech/substrate#12277
  • [x] We should also make the fields of Weight #[compact], and include that in the migration: https://github.com/paritytech/substrate/issues/12149
  • [x] We will also need to make frame executive respect both weight fields, and behave correctly. paritytech/substrate#12383
• [x] A dynamic way of allowing chains to update their max proof size? https://github.com/paritytech/substrate/pull/12383#discussion_r983275063
• [ ] Record PoV size in benchmark overhead https://github.com/paritytech/polkadot-sdk/issues/384

Once we get to that point, we will need to double check our logic around benchmarking and PoV, and we can open a new tracking issue for that.

[Polkadot-Forum]

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/weight-v2-discussion-and-updates/227/4

[Polkadot-Forum]

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/xcm-latest-updates/389/2

[Polkadot-Forum]

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis/1026/2

[kianenigma]

I would also consider paritytech/polkadot-sdk#209 as critical part of considering this done.