paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 654 forks source link

Funds not `trapped` after `polkadotXcm.Attempted` returns `FailedToTransactAsset` #3797

Open Juanma0x opened 6 months ago

Juanma0x commented 6 months ago

Is there an existing issue?

Experiencing problems? Have you tried our Stack Exchange first?

Description of bug

The XCM extrinxic 6353817-2 in Kusama Asset Hub resulted in an Attempted FailedToTransactAsset error because the account tried to transfer all transferable funds.

Due to the limitations of the new delivery fees manager, the funds should have been trapped but were instead just withdrawn.

Related: https://github.com/paritytech/polkadot-sdk/issues/690 https://github.com/paritytech/polkadot-sdk/issues/3434 https://github.com/paritytech/polkadot-sdk/pull/3450

This could impact the total issuance.

Steps to reproduce

No response

Juanma0x commented 5 months ago

I'll add another case that might be affected by the same bug:

Transactions failed in Polkado Asset Hub: https://assethub-polkadot.subscan.io/xcm_message/polkadot-57b7063a03798764c36226132fae6145f7b150b4

I don't see any "trapped" balance. The sender account had enough to pay for the fees in ACA, and some DOT (0.016 DOT) were transferred to pay for the destination fee.

According to Joe, 0.016 DOT were not enough and the balance dropped below the ED.