paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

Closed alvicsam closed 2 days ago

alvicsam commented 2 weeks ago

cc https://github.com/paritytech/ci_cd/issues/1035

cc https://github.com/paritytech/ci_cd/issues/1023

alvicsam commented 2 weeks ago

/cmd help

github-actions[bot] commented 2 weeks ago

Command "help" has started 🚀 See logs here

github-actions[bot] commented 2 weeks ago

Command "help" has failed ❌! See logs here

alvicsam commented 2 weeks ago

bot fmt

command-bot[bot] commented 2 weeks ago

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-f635b668-ec61-4fba-8c53-6d0873da4411 to cancel this command or bot cancel to cancel all commands in this pull request.

alvicsam commented 2 weeks ago

bot help

command-bot[bot] commented 2 weeks ago

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086/artifacts/download.

command-bot[bot] commented 2 weeks ago

Here's a link to docs

alvicsam commented 2 weeks ago

bot -v CMD_IMAGE=docker.io/paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 fmt

command-bot[bot] commented 2 weeks ago

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-69c20856-38ce-4cb3-90f3-359d2f53dde3 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 2 weeks ago

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088/artifacts/download.

alvicsam commented 2 weeks ago

bot update-ui latest --rust_version=1.81

command-bot[bot] commented 2 weeks ago

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-ab4bc0bc-095e-4f2b-8ae0-24b6a3628629 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 2 weeks ago

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182/artifacts/download.

alvicsam commented 2 weeks ago

@ggwpez could you please help with the CI errors (tests, clippy)?

ggwpez commented 2 weeks ago

@gui1117 i applied your fix here, just FYI

nazar-pc commented 2 weeks ago

What about merging https://github.com/paritytech/polkadot-sdk/pull/5317 first with rust-toolchain.toml (see https://github.com/paritytech/polkadot-sdk/issues/5335)?

bkchr commented 2 weeks ago

@ggwpez please do not sprinkle everywhere allow(dead_code). Maybe for some things it could stay, but some stuff can also be removed or put behind the feature as the code in which it is being used.

athei commented 1 week ago

@ggwpez please do not sprinkle everywhere allow(dead_code). Maybe for some things it could stay, but some stuff can also be removed or put behind the feature as the code in which it is being used.

Agreed. We should use the opportunity of improved dead code detection to get rid of what we don't need. Thanks for doing this @ggwpez ❤️

ggwpez commented 1 week ago

Something in the orchestrator crate seems to emit code that trigger clippy:


error: trait `OrchestraFieldState` is never used
     --> /__w/polkadot-sdk/polkadot-sdk/target/debug/build/expander-f21e58b59c39b7b5/out/orchestra-expansion-d13355006895.rs:14155:7
      |
14155 | trait OrchestraFieldState<T> {}
      |       ^^^^^^^^^^^^^^^^^^^
      |
      = note: `-D dead-code` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(dead_code)]`

    Rustc finished with error: exit status 1
error: could not compile `polkadot-overseer` (lib) due to 1 previous error
ggwpez commented 5 days ago

Looking for one review from @bkontur, @serban300 or @acatangiu and then we can merge.