paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

pallet-treasury: Improve `remove_approval` benchmark #5713

Closed bkchr closed 1 week ago

bkchr commented 2 weeks ago

When SpendOrigin doesn't return any succesful_origin, it doesn't mean that RejectOrigin will do the same. Thus, this pr fixes a potential wrong benchmarked weight for when SpendOrigin is set to e.g. NeverOrigin.

paritytech-cmd-bot-polkadot-sdk[bot] commented 1 week ago

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5713-to-stable2407
git worktree add --checkout .worktree/backport-5713-to-stable2407 backport-5713-to-stable2407
cd .worktree/backport-5713-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9cdbdc5a73f3c2d1d9afdf266799f249c3c04c2d
git push --force-with-lease
paritytech-cmd-bot-polkadot-sdk[bot] commented 1 week ago

Successfully created backport PR for stable2409: