paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.88k stars 688 forks source link

bot bench: Allow passing feature flags #5714

Closed xermicus closed 1 month ago

xermicus commented 1 month ago

pallet-revive requires the riscv feature for benchmarks. We don't want to add it to runtime-benchmarks as that will require everybody else to have the rve toolchain installed. So we'd need a way to pass flags to the bot, however this doesn't seem to be supported currently? I imagine something like this should work: https://github.com/paritytech/polkadot-sdk/pull/5675#issuecomment-2343547579

mordamax commented 1 month ago

Not a problem to add, though we're going to deprecate this command bot along with old benchmarks, now we have the other command bot built as GHA, and it uses frame-omni-bencher. I suspect this still will require riscv feature to be added in your case?

xermicus commented 1 month ago

Yeah we need the rve toolchain and a way to set the feature flag in the omni bencher and we should be good. Thanks!

athei commented 1 month ago

Just always enabling the riscv feature when benchmarking is good enough. That should be easier to implement than adding another command to parse. Both would work for us.

athei commented 1 month ago

Is there any progress on this? Sorry don't want to be pushy but we can't really run benchmarks without this.

mordamax commented 1 month ago

@athei sorry for delay, will be done today 👌