search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

API `fn try_append` is missing for StorageNMap #5722

Closed shawntabrizi closed 5 days ago

shawntabrizi commented 1 week ago

Storage Map has try_append for pushing to a bounded vec: https://crates.parity.io/frame_support/pallet_prelude/struct.StorageMap.html#method.try_append

Storage N Map is missing this API: https://crates.parity.io/frame_support/pallet_prelude/struct.StorageNMap.html

rainbow-promise commented 1 week ago

Hey @shawntabrizi, I would like to take this on!

CJ13th commented 1 week ago

Sorry for the confusion @rainbow-promise, I saw this one via email notification and started working on it before I realised someone else had expressed interest. Hopefully we haven't duplicated our efforts! @shawntabrizi I have submitted a pull request for this here #5745 if you wouldn't mind taking a look?

shawntabrizi commented 1 week ago

@CJ13th please do notify in the github issue next time :)

but no harm i think. maybe @rainbow-promise if you are interested you can do a code review along with us?

rainbow-promise commented 1 week ago

@CJ13th please do notify in the github issue next time :)

but no harm i think. maybe @rainbow-promise if you are interested you can do a code review along with us?

Happy to @shawntabrizi and no problem @CJ13th, many other issues available.