paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

Ensure nomination pool members can directly stake and vice versa. #5742

Open Ank4n opened 1 week ago

Ank4n commented 1 week ago

Context

As a side effect of https://github.com/paritytech/polkadot-sdk/pull/3905, it becomes possible for a direct staker to reuse the staked (frozen) funds to be used for participating in a pool (hold) as well. Essentially double staking with the same funds.

This is prevented currently by pallet-delegated-staking not allowing direct stakers to delegate, as well as by pallet-staking only taking free balance into account.

Task

As a followup to https://github.com/paritytech/polkadot-sdk/pull/5501, remove the condition to not be a direct staker for bonding to pool.

rainbow-promise commented 1 week ago

Hello @Ank4n I would like to take this issue.

Ank4n commented 1 week ago

Hello @Ank4n I would like to take this issue.

@rainbow-promise Thanks for your interest. This issue can only be done post #5501, and only requires one line to remove. I would suggest to pick up an issue with C1-Mentor.