paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.89k stars 696 forks source link

Add Snowbridge initialize migration on Westend #5747

Closed yrong closed 1 month ago

yrong commented 1 month ago

Description

Fix https://github.com/paritytech/polkadot-sdk/pull/5074 which missed the runtime migration to initialize channels of the bridge.

claravanstaden commented 1 month ago

This is not really a backport, so perhaps change the title to "Add Snowbridge initialize migration on Westend", otherwise the title is misleading.

yrong commented 1 month ago

https://github.com/paritytech/polkadot-sdk/actions/runs/10923847845/job/30321556177?pr=5747

check-runtime-migration(bridge-hub-rococo) fails though seems nothing to do with this PR. Tested with try-runtime-cli and it work as expected as follows:

➜  polkadot-sdk git:(snowbridge-westend-migration) ✗ RUST_LOG=ethereum_system try-runtime --runtime ./target/release/wbuild/bridge-hub-westend-runtime/bridge_hub_westend_runtime.compact.compressed.wasm on-runtime-upgrade --checks=pre-and-post live --uri wss://westend-bridge-hub-rpc.polkadot.io:443
✅ Found 6698 keys (3.23s)
[00:00:17] ✅ Downloaded key values 391.0557/s [====================================================================================================================================================] 6698/6698 (0s)
✅ Inserted keys into DB (0.03s)
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Agents and channels not initialized. Initialization will run.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system initialized.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system initialized.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Agents and channels are initialized. Initialization will not run.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system already initialized. Skipping.

@acatangiu Is there anything required left for this PR?

acatangiu commented 1 month ago

@yrong just some spurious network issues leading to some CI tests failing, restarted those CI jobs, should be auto-merged when they finish

paritytech-cmd-bot-polkadot-sdk[bot] commented 1 month ago

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5747-to-stable2407
git worktree add --checkout .worktree/backport-5747-to-stable2407 backport-5747-to-stable2407
cd .worktree/backport-5747-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 86bb5cb5068463f006fda3a4ac4236686c989b86
git push --force-with-lease
paritytech-cmd-bot-polkadot-sdk[bot] commented 1 month ago

Successfully created backport PR for stable2409: