search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.91k stars 704 forks source link

Collation fetching fairness - handle group rotations #5754

Open tdimitrov opened 2 months ago

tdimitrov commented 2 months ago

Related to https://github.com/paritytech/polkadot-sdk/issues/1797 and follow up from https://github.com/paritytech/polkadot-sdk/pull/4880

On group rotation we could end up in the case where a fully backed candidate is provided by the old group for a claim queue slot falling into the next one. For example the claim queue holds paras [A, B, A] at RPX and two candidates for para A are provided. At RP X+1 a group rotation occurs. Now the claim queue has got [B, A, ...]. The second slot (A) is already claimed by the old validator group however the new one doesn't know about this. As a result we will end up with one additional collation.

This issue was initially reported by @eskimor: https://github.com/paritytech/polkadot-sdk/pull/4880#discussion_r1684411976

Oyase-shinobi commented 2 months ago

Hello @tdimitrov How are you doing as I am a blockchain and web3 frontend developer, I would love to engage in your team is there any opportunity to work with you?

tdimitrov commented 2 months ago

Hey @Oyase-shinobi. Thank you for your interest in polkadot-sdk! I am already working on this particular issue but if you are interested in contributing to the project I'd suggest to have a look at the issues tagged with 'good first issue': https://github.com/paritytech/polkadot-sdk/labels/C2-good-first-issue If you find something which you like write in the issue and ask to be assigned to it. You'll get help, feedback, code reviews etc.

Sounds like a plan?

Oyase-shinobi commented 2 months ago

Thank you for reaching out me Could you tell me about your discord ID for better communication