Closed x3c41a closed 1 month ago
bot fmt
Request changes
Do not remove existing converters to maintain backwards compatibility (see following comments)
Testing
For each chain/runtime, please add unit tests (faster/easier than emulated tests) that cover the newly supported conversions.
E.g. you can add new test for asset-hub-westend here, then run it with
cargo test -r -p asset-hub-westend-runtime
. Do the same for other runtimes too.In terms of how to test, very easy way is using LocationToAccountHelper::convert_location()` and pass it locations that use to fail conversion, but with your change now succeed.
You can see an example of how to call
LocationToAccountHelper
here.
Added the tests. Additionally removed my change and made sure that the tests fail.
bot fmt
bot fmt
bot clean
Review required! Latest push from author must always be reviewed
Added
HashedDescription<AccountId, DescribeFamily<DescribeAllTerminal>>
foreign locations to local accounts converter to all the parachains.