paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.89k stars 696 forks source link

Added foreign locations to local accounts converter to all the parachains #5765

Closed x3c41a closed 1 month ago

x3c41a commented 1 month ago

Added HashedDescription<AccountId, DescribeFamily<DescribeAllTerminal>> foreign locations to local accounts converter to all the parachains.

bkontur commented 1 month ago

bot fmt

x3c41a commented 1 month ago

Request changes

Do not remove existing converters to maintain backwards compatibility (see following comments)

Testing

For each chain/runtime, please add unit tests (faster/easier than emulated tests) that cover the newly supported conversions.

E.g. you can add new test for asset-hub-westend here, then run it with cargo test -r -p asset-hub-westend-runtime. Do the same for other runtimes too.

In terms of how to test, very easy way is using LocationToAccountHelper::convert_location()` and pass it locations that use to fail conversion, but with your change now succeed.

You can see an example of how to call LocationToAccountHelper here.

Added the tests. Additionally removed my change and made sure that the tests fail.

acatangiu commented 1 month ago

bot fmt

acatangiu commented 1 month ago

bot fmt

acatangiu commented 1 month ago

bot clean

github-actions[bot] commented 1 month ago

Review required! Latest push from author must always be reviewed