paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.92k stars 707 forks source link

E2E test for runtime upgrades #5817

Open alexggh opened 2 months ago

alexggh commented 2 months ago

https://github.com/paritytech/polkadot-sdk/issues/5738, Postmortem, has showed that we have a gap in testing with regards to runtime upgrades, one of the action items in the post mortem is to have E2E test where:

  1. Spawn a zombienet test with the runtime version Westend/Rococo testnet is running.
  2. Upgrade the runtime to the latest version a PR introduces.
  3. Check various asserts hold true immediately after the runtime upgrade, ideas of things we can check:
    • All runtime ParachainHostAPIs return expected values.
    • Parachains are producing blocks as expected around the blocks we did the runtime upgrade.
pepoviola commented 2 months ago

Part of the test is implemented here https://github.com/paritytech/polkadot-sdk/pull/5794. We should add the checks you mention. Thx!

tdimitrov commented 2 months ago

We also did runtime upgrade with zombienet-sdk during for the disabling tests - https://github.com/paritytech/disabling-e2e-tests/blob/452ba09ed6874e4b5a55dedb338b669cabcbf8f0/src/lib.rs#L212

pepoviola commented 2 months ago

I added a helper into zombienet to make more easy to permorm upgrades 😃