Get rid of `libp2p` dependency in `sc-authority-discovery`

[ndkazu]

Issue

4859

Description

This PR removes libp2p types in authority-discovery, and replace them with network backend agnostic types from sc-network-types. The sc-network interface is therefore updated accordingly.

[ndkazu]

A bot fmt is needed, and also a label.

[ndkazu]

bot fmt needed

[dmitry-markin]

bot fmt

[command-bot[bot]]

@dmitry-markin https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7471948 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-0a9426d8-7764-4b72-8a95-ce6347a9c4b1 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot[bot]]

@dmitry-markin Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7471948 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7471948/artifacts/download.

[ndkazu]

@dmitry-markin , @bkchr , @lexnv , I think we're ready for a review.

[ndkazu]

It seems that I cannot add new reviewers myself: I don't see the gear usuallly present on the right side of Reviewers

[dmitry-markin]

@ndkazu thanks for looking into this issue and sorry for slow reviews on my side.

[ndkazu]

@dmitry-markin , what about litep2p ? keep it or remove/replace it? I see the following import: litep2p::protocol::libp2p::bitswap::{ BitswapEvent, BitswapHandle, BlockPresenceType, Config, ResponseType, WantType, };

[dmitry-markin]

bot fmt

[command-bot[bot]]

@dmitry-markin https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7724737 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 65-3e7512e2-ac5c-4e3f-a7b8-50230bc1b3da to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot[bot]]

@dmitry-markin Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7724737 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7724737/artifacts/download.

[dmitry-markin]

@dmitry-markin , what about litep2p ? keep it or remove/replace it? I see the following import: litep2p::protocol::libp2p::bitswap::{ BitswapEvent, BitswapHandle, BlockPresenceType, Config, ResponseType, WantType, };

Nothing wrong with this. This line means we are importing libp2p bitswap protocol implementation from litep2p.

[ndkazu]

Good to merge? :eyes:

[dmitry-markin]

Good to merge? 👀

Let me have a look why zombienet tests are failing.

[dmitry-markin]

@alvicsam can you have a look please? GitHub seems to be stuck in this PR. "Processing updates" is spinning on top of the page since yesterday, and the last commit is not visible in the UI. Merging is also blocked.

[alvicsam]

I have no idea tbh, I'm seeing this first time. Not sure what I can do from my side, it looks as some internal github issue. I can only suggest to push an empty commit to re-trigger the update process.

[alvicsam]

People in the related community discussion advice to turn it off and on again close and reopen the PR.

[dmitry-markin]

I have no idea tbh, I'm seeing this first time. Not sure what I can do from my side, it looks as some internal github issue. I can only suggest to push an empty commit to re-trigger the update process.

It worked! Thanks @alvicsam

[dmitry-markin]

Hey @ndkazu, thanks for contributing! Good job here!

[ndkazu]

Hey @ndkazu, thanks for contributing! Good job here!

Let's close the issue and think about the next step? 😃