paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.86k stars 682 forks source link

Probably incorrect one test of disputes #5900

Closed xDimon closed 4 weeks ago

xDimon commented 1 month ago

In the test participation_with_onchain_disabling_confirmed I see two opposing votes - valid from baker and invalid from disabled validator. But although second validator named as disabled, his index is not return in result of query disabled validator (query returns empty list). It seems as mistake in test. Without that test looks like as regular scenario of dispute escalation.

xDimon commented 1 month ago

cc @ordian

ordian commented 1 month ago

Indeed, good catch! Luckily, the corrected test still passes :)