paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.85k stars 675 forks source link

Confusing terminology for coretime sales #6037

Open mafux777 opened 2 weeks ago

mafux777 commented 2 weeks ago

According to Coretime Docs the sale "proper" only starts after the renewal period. This is also the date that is fired by the SalesInitialized event, labelled sale_start

However, there is an event fired SalesStarted which fires one week earlier, namely on the date that renewals start.

The dual use of the term "sales start" referring to different events is super confusing.

My suggestion would be to avoid the use of "sale start" and be more explicit: renewal_start discovery_start auction_start

bkchr commented 1 week ago

You mean to rename the event?