search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.com/
1.89k stars 696 forks source link

parachain build error with polkadot-stable2407-3, as patched crates are missing vendoring #6185

Closed clangenb closed 3 weeks ago

clangenb commented 3 weeks ago

Is there an existing issue?

Experiencing problems? Have you tried our Stack Exchange first?

Description of bug

I had to downgrade a few crates after upgrading to 2024-3 with psvm because the crates haven't been found. The affected crates can be seen here, https://github.com/ajuna-network/ajuna-parachain/commit/13c02b8b20e908e6551114e49933c84d5d354e56.

Downgrading them fixes the issue.

Steps to reproduce

  1. Get a parachain
  2. run psvm -v polkadot-stable2407-3
  3. cargo tree -i -p sp-core
xlc commented 3 weeks ago

related: https://github.com/polkadot-fellows/runtimes/issues/493

I raised this issue somewhere (can't find it anymore, I guess I asked someone in one of the Element room), but essentially the patch are not published to crates.io, which is very bad.

clangenb commented 3 weeks ago

Hmm, I see. I agree that this should be fixed. Otherwise, the only one who benefit from patches are node operators or devs who depend on the git source of the polkadot sdk. But the latter don't need to care about releases in the first place. Thanks for answering.

I will close this issue though in favor of https://github.com/paritytech/polkadot-sdk/issues/6206, as the underlying issue is the same.